Sleeping does not indicate auth lock status
beikeland opened this issue · comments
beikeland commented
While auth lock works correctly when sleeping and waking up the auth lock is not shown on the LCD regardsless of lock being set before or during sleep, would be handy to have this shown correctly.
Edit: Not sure about the colour usage, but seems to work otherwise:
diff --git a/firmware/open_evse/open_evse.ino b/firmware/open_evse/open_evse.ino
index 643d32e..365cb91 100644
--- a/firmware/open_evse/open_evse.ino
+++ b/firmware/open_evse/open_evse.ino
@@ -727,9 +727,14 @@ void OnboardDisplay::Update(int8_t updmode)
SetGreenLed(0);
SetRedLed(1);
#ifdef LCD16X2
- LcdSetBacklightColor(VIOLET);
LcdClear();
LcdSetCursor(0,0);
+ if (g_EvseController.AuthLockIsOn()) {
+ LcdSetBacklightColor(TEAL);
+ LcdWrite(4);
+ }
+ else
+ LcdSetBacklightColor(VIOLET);
LcdPrint_P(g_psDisabled);
LcdPrint(10,0,g_sTmp);
#endif // LCD16X2
@@ -748,9 +753,14 @@ void OnboardDisplay::Update(int8_t updmode)
SetGreenLed(1);
SetRedLed(1);
#ifdef LCD16X2
- LcdSetBacklightColor(g_EvseController.EvConnected() ? WHITE : VIOLET);
LcdClear();
LcdSetCursor(0,0);
+ if (g_EvseController.AuthLockIsOn()) {
+ LcdSetBacklightColor(TEAL);
+ LcdWrite(4);
+ }
+ else
+ LcdSetBacklightColor(g_EvseController.EvConnected() ? WHITE : VIOLET);
LcdPrint_P(g_psSleeping);
LcdPrint(10,0,g_sTmp);
#endif // LCD16X2
lincomatic commented
Thanks, I pushed the change in D6.1.1. I decided not to change the color of the LCD, since it might be too confusing