Change in v3.6.0 tag?
scpeters opened this issue · comments
The libbitcoin* homebrew formulae were updated to use tags named v3.6.0 on 2019-08-09 in Homebrew/homebrew-core#42910, but a recent homebrew build complains that the sha256 of the GitHub archive has changed:
Sometimes this happens on GitHub, but I noticed that the Github Release page for v3.6.0 says that the release occurred on 2019-08-29. Was the tag (or tags) changed intentionally?
@thecodefactory welcome to release control :)
@scpeters Mea culpa! I tagged v3.6.0 a little while ago, but it was missing some recent fixes, and contained the incorrect version number. After getting that updated, I removed the tags and re-tagged (so yes, intentionally). I apologize for breaking systems that relied on it.
Knowing this, how bad is the homebrew damage?
@evoskuil Yippee :-)
Just the wrong hash. But it's generally better to ask upstream if they meant to do this.
Just the wrong hash. But it's generally better to ask upstream if they meant to do this.
@SMillerDev Got it, thanks!
yeah, it's not the end of the world, and I wanted to confirm that it was an intentional change and not a glitch in GitHub
I've always viewed tags as something that should be permanent, so in the projects I maintain, I always just increment the version number and make a new tag, like 3.6.1 in this case. Just something to think about.
Cheers!