lcrawlab / SINATRA

A statistical framework for feature selection and association mapping with 3D shapes

Home Page:https://projecteuclid.org/journals/annals-of-applied-statistics/volume-15/issue-2/A-statistical-pipeline-for-identifying-physical-features-that-differentiate-classes/10.1214/20-AOAS1430.full

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Recommendation: Break package out

muschellij2 opened this issue · comments

Recommendation - break out the paper_results branch into a different repo (or the package itself into another repo). Reason: 170mb .git folder (git history). Mix of package + paper results.

That's a good recommendation! There's definitely some junk in there to prune, I've noticed that the package itself is ~300mb 😬

I have made a lot of changed and refactored a bit of stuff - I really liked the talk from @lorinanthony today, so hopefully this helps to push it over the line: https://github.com/muschellij2/SINATRA

That is so kind of you, thank you! We will work to merge the changes you made into our repo. I took a brief look at the changes, they have definitely made this package more usable and less clunky :).

Thanks so much for doing this @muschellij2! This is incredible! @brwaang55 should we think about merging these edits (if John does not mind)? I agree this really cleaned the package.

@lorinanthony This can also be resolved, the paper results and working version of SINATRA for the AOAS paper is in here. Please look there to have working scripts and tutorials.

Awesome!