jmschrei / apricot

apricot implements submodular optimization for the purpose of selecting subsets of massive data sets to train machine learning models quickly. See the documentation page: https://apricot-select.readthedocs.io/en/latest/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing dependencies: scikit-learn, pytorch

tschuelia opened this issue · comments

Hi! I think the setup.py install_requires is missing scikit-learn and pytorch.

scikit-learn version needs to be >= 0.22 (sklearn.neighbors. KNeighborsTransformer added in version 0.22)

It looks like PyTorch is never used, the import torch in apricot/functions/featureBased.py can be removed I guess? In this case only the scikit-learn dependency needs to be added