Giters

jhelovuo / RustDDS

Rust implementation of Data Distribution Service

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

SequenceNumber wrong decl.

frehberg opened this issue · comments

commented

This definition is not according to RTPS Spec

pub struct SequenceNumber(i64);

IDL Definition is as follows. Current decl. may cause bad encoding/decoding and bad wrong CDR alignment.

struct SequenceNumber_t {
long high;
unsigned long low;
};
commented

Yes, your observation is correct, the data structure definition is not the closest equivalent to IDL definition.

However, this is supposed to be RustDDS internal representation. The external representation is defined in Readable and Writable implementations for SequenceNumber, which do follow IDL, i.e. treat SequenceNumber as two 32-bit numbers.

Do you have an example where this causes problems?

commented

Ok, I see. In this case it is not an issue, and this ticket can be closed