jagandeep / order-dispatch-kata

A legacy refactor kata, focused on the violation of the tell don't ask principle and anemic domain model

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Order Dispatch Kata

A legacy refactor kata, focused on the violation of the tell don't ask principle and the anemic domain model.

Instructions

Here you find a simple order flow application. It's able to create orders, do some calculation (totals and taxes), and manage them (approval/reject and shipment).

The old development team did not find the time to build a proper domain model but instead preferred to use a procedural style, building this anemic domain model. Fortunately, they did at least take the time to write unit tests for the code.

Your new CTO, after many bugs caused by this application, asked you to refactor this code to make it more maintainable and reliable.

What to focus on

As the title of the kata says, of course, the tell don't ask principle. You should be able to remove all the setters moving the behavior into the domain objects.

But don't stop there.

If you can remove some test cases because they don't make sense anymore (eg: you cannot compile the code to do the wrong thing) feel free to do it!

Credit

The Kata was originally authored by @racingDeveloper
Typescript and Python3 versions by mapu77
PHP version by Archel
CSharp version by raullorca
Kotlin and Java+Lombok versions by @gregor_riegler

About

A legacy refactor kata, focused on the violation of the tell don't ask principle and anemic domain model

License:GNU General Public License v3.0


Languages

Language:Java 27.0%Language:PHP 18.4%Language:C# 17.0%Language:TypeScript 13.8%Language:Python 12.9%Language:Kotlin 10.9%