[Bug] Account names don't display emoji properly

Question

[Bug] Account names don't display emoji properly

pioneer opened this issue 5 years ago · comments

Users that have HTML markup in their names appear with the HTML unrendered, which is definitely not the way that is expected.

To Reproduce

Subscribe to an account such as archlinux@pokemon.men
Open it in Hyperspace
Compare how it's rendered in the Mastodon UI

Expected behaviour
An account name should be rendered much prettier than having HTML unrendered. I believe HTML should be either stripped away or rendered in a safe manner somehow (or just unsafely as Mastodon does I suppose).

Screenshots
See the screenshot how it looks - https://pasteboard.co/IQeT0tB.png
The same account in the original Mastodon UI - https://pasteboard.co/IQeUgf0.png

App Information:
Hyperspace 1.1.0 Dev Channel

issue-label-bot · Answer 1 · Thu Jan 16 2020 22:04:54 GMT+0800 (China Standard Time)

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Marquis Kurt · Answer 2 · Thu Jan 16 2020 22:56:31 GMT+0800 (China Standard Time)

Appears to be a stripping HTML issue. Marked as HD-39 in internal and set for epic v1.1.0-beta3.

Marquis Kurt · Answer 3 · Thu Jan 16 2020 23:47:05 GMT+0800 (China Standard Time)

It turns out this bug was an issue with the way #144 was implemented and that it didn't pass on dangerouslySetInnerHTML, meaning emojis wouldn't be displayed properly. Renaming the bug and waiting for a fix with #155

Marquis Kurt · Answer 4 · Sat Jan 18 2020 03:52:50 GMT+0800 (China Standard Time)

I'll also assign you to the PR then, @travisk-codes