girder / viime

Home Page:https://viime.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wilcox and ANOVO Volcano plots don't seem to render.

waxlamp opened this issue · comments

Looks like the ANOVA volcano plot not rendering happens when the ANOVA test fails. If ANOVA fails we now catch that and display an error in the ANOVA page (#599) but not in the ANOVA volcano plot page. Should be able to parse the response from the ANOVA analysis and display an error message for the volcano plot.

https://viime.org/#/app/pretreatment/dbe03b9d-8007-4508-9de2-a138d7402580/analyze/anova_volcano

I addressed the ANOVA errors in #631. For the Wilcoxon plot render error, I suspect this is the cause of the plot not rendering - https://sentry.io/organizations/kitware-data/issues/1822253993/?project=1814175&query=is%3Aunresolved
Unfortunately I'm still unable to reproduce the Wilcoxon error locally, even using the exact same dataset as the one in that sentry error.

I can modify the R code to catch errors in the wilcoxon test like I did for ANOVA, but in that case those errors were completely normal in the sense that ANOVA tests can sometimes fail mathematically. It seems based on the sentry error that the wilcoxon test might be failing because of a programming error, which should be fixed instead of being displayed as a user error.

I can modify the R code to catch errors in the wilcoxon test like I did for ANOVA, but in that case those errors were completely normal in the sense that ANOVA tests can sometimes fail mathematically. It seems based on the sentry error that the wilcoxon test might be failing because of a programming error, which should be fixed instead of being displayed as a user error.

We can at least display this kind of error as a server error, and that gives the user closure (rather than leaving them wondering what's going on).

I'll ask Lilian to look into programming errors in the Wilcoxon test code.

@jkanche, I believe this is now fixed. Please take a look and re-open this issue if you find lingering problems. Thanks!

Hi! I didn't submit this one, but I still can't see anything upon running the ANOVA/Wilcox. volcano plots, I assume there should be some kind of error/no hits found message? But in my case I did have hits in the ANOVA/Wilcox.. 😮
image

@joannawolthuis, could you show me what your Cleanup Table looks like for this dataset?

@waxlamp Hi, thanks for your response!
I think it fixed itself - once I went back to the Clean Up table to de-select and re-select the metadata column (for the boxplots split by group not loading, other issue), both volcano plots loaded. Seems it's a connected issue - and since you're already working on that you can close this if you want :)