foxglove / ws-protocol

Description

I find that the C++ implementation in this repo diverges from https://github.com/foxglove/ros-foxglove-bridge/tree/main/foxglove_bridge_base

The implementation of setupTlsHandler() https://github.com/foxglove/ros-foxglove-bridge/blob/main/foxglove_bridge_base/src/server_factory.cpp is missing.

The examples get away by defining empty specialization inside the example source.

ws-protocol/cpp/examples/src/example_server_protobuf.cpp

Lines 19 to 22 in 04d8f95

    
           namespace foxglove { 
        
           template <> 
        
           void Server<WebSocketNoTls>::setupTlsHandler() {} 
        
           }  // namespace foxglove

Is this intentional? Is it the consumer's responsibility to define this?

Thanks in advance.

Version:
Platform: C++ / Ubuntu 22.04

Steps To Reproduce

...

Expected Behavior

...

Internal tracking ticket: FG-4983

Yeah, I'm aware that this is a nuisance. Will look for a solution to fix this

Thanks 👍.

Is there anything speaking against borrowing this implementation?
https://github.com/foxglove/ros-foxglove-bridge/blob/main/foxglove_bridge_base/src/server_factory.cpp

If not, would you be open to a PR?

Is there anything speaking against borrowing this implementation? https://github.com/foxglove/ros-foxglove-bridge/blob/main/foxglove_bridge_base/src/server_factory.cpp

I did exactly that in #545. Does that work for you?

Lovely! Looks good.

Thanks 😃

	namespace foxglove {
	template <>
	void Server<WebSocketNoTls>::setupTlsHandler() {}
	} // namespace foxglove

Missing implementation of setupTlsHandler (C++)