facebookarchive / react-page-middleware

Connect/Express middleware to use React to generate whole websites

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

JSX compilation errors during bundling should reveal more information in traceback

tlack opened this issue · comments

The react-page error handler helpfully shows you stack traces when things go wrong, but in the case of a compilation error with one of your .jsx files, the error is less than helpful:

SyntaxError: Unexpected identifier
    at renderReactPage (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/renderReactPage.js:91:12)
    at renderComponentPackage (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/DefaultRouter.js:338:3)
    at routePackageHandler (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/DefaultRouter.js:281:5)
    at onComputePackage (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/index.js:100:9)
    at /home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/guard.js:29:10
    at onWarmed (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/Packager.js:281:9)
    at /home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/node_modules/async/lib/async.js:116:25
    at /home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/node_modules/async/lib/async.js:24:16
    at transformModuleImpl (/home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/Packager.js:217:5)
    at /home/tlack/node-apps/lump/react-page/node_modules/react-page-middleware/src/Packager.js:245:9

In this case, lump/react-page/src/view/index.js was at fault - I didn't use the @jsx comment correctly. But that's hard to tell from the stack trace shown here.

BTW, renderReactPage.js:91:12 is the vm.runInNewContext() stuff.