Find a bug in gemsiv/clahe.c

Question

Find a bug in gemsiv/clahe.c

liandaoacc opened this issue 7 years ago · comments

In gemsiv/clahe.c, lin 226, pImage = &pImagePointer[uiSizeX]; should be pImage = &pImagePointer[-uiSizeX];. At the original version, it is pImage = &pImagePointer[-uiSizeX];.

Eric Haines · Answer 1 · Wed Feb 22 2017 21:52:33 GMT+0800 (China Standard Time)

Thanks very much, and it's now fixed. The commit here introduced this problem a year ago, and it slipped by me in review among the endless casting changes. I've gone over the submission again and believe no other bugs were introduced.

Gonsolo · Answer 2 · Fri Mar 17 2017 18:37:08 GMT+0800 (China Standard Time)

There was a problem before my commit: Unary minus of an unsigned int gives an unsigned int which probably not what you want here. I have the correct fix in my repository. Please pull.
gonsolo@5eff48b

Eric Haines · Answer 3 · Sat Mar 18 2017 09:05:44 GMT+0800 (China Standard Time)

Thanks, and fixed (no idea how to make a pull request from your branch; I thought you'd submit a PR for me to accept).