django-cms / djangocms-admin-style

django CMS Admin Style is a Django Theme tailored to the needs of django CMS.

Home Page:http://www.django-cms.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Calendar next/previous links are invisible

jsma opened this issue · comments

The shortcut links < and > on the calendar widget are invisible.

screen shot 2016-06-16 at 5 04 07 pm

Technically, the top left and right corners of the widget are still clickable, but since the editors can't see them, they assume they don't exist, leading to frustration and confusion.

I've tested against both 1.2.2 and the most recent commit fa1838d and the problem exists in both versions. Also, I've confirmed that if I disable djangcms-admin-style, Django's default calendar widget does not have this issue.

thank you for the report @jsma . Any chance you could create a PR to fix this?

Django's widgets.css applies text-indent: -9999px; to the prev/next links. If I disable this style in Chrome dev tools, the arrows reappear (but the alignment is off a bit).

screen shot 2016-06-17 at 11 45 29 am

I'm not sure what the root issue is though, since this CSS works just fine in the standard Django admin. Unfortunately, I'm not going to be able to get a quality PR together anytime soon.

thank you @jsma we'll have a look then :)

@jsma I just had a look and in latest master it looks correctly:

image

Did you check it out with the latest master version?

Yes, I just installed via pip install git+https://github.com/divio/djangocms-admin-style.git and the issue persists. I've also confirmed that my browser is loading the CSS from this install, and not any cached versions. I should also note I'm on Django==1.9.7.

ah I haven't tried Django 1.9 yet, will do that then :) thanks @jsma

Closed in the latest master @jsma thanks to @lory87 . Will be released this week :)