cta-observatory / ctapipe_io_lst

ctapipe IO plugin for LST prototype data

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

EventSource.subarray must be a property

maxnoe opened this issue · comments

Currently the lst event source deviates from the API of the baseclass, which makes it impossible to use in programs that just use the generic EventSource and rely on a common API.

Hi @maxnoe,
yes, I think the implementation of the subarray was not orthodox, could you indicate a source with the correct API, to take as example?

ctapipe.io.EventSource is the abstract baseclass, which has the API we need to implement.

.subarray needs to be a simple property, so one can do:

event_source = ...
print(event_source.subarray)