commaai / opendbc

democratize access to car decoder rings

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Toyota DBC cleanup

adeebshihadeh opened this issue · comments

Ideally, we can use a single DBC for all Toyotas, like we do with many of the more recent car ports. This can be done incrementally by doing the following:

  • merging DBCs
  • using common, universal signals when possible
  • abstracting out repeated definitions into common DBCs

Alright, @cydia2020 got the quick ones out of the way. The top remaining things seem to be:

  • common gear packet #464
  • common gas pedal signal. some cars use 581 and others use 705
  • EPS steer torque factor

I'll look into the steer torque factor myself once the rest is done.

Gas pedal message seems to be split by Hybrid / ICE. I opened #505, but it would be better if we can find a common signal. Perhaps one of the two is on all cars? Maybe we'll have to find a new signal.

Looks like there's also a different brake mesage

batman:toyota$ rg BRAKE_MODULE
toyota_prius_2017_pt.dbc
10:BO_ 550 BRAKE_MODULE: 8 XXX

toyota_rav4_2017_pt.dbc
4:BO_ 548 BRAKE_MODULE: 8 XXX

lexus_ct200h_2018_pt.dbc
4:BO_ 548 BRAKE_MODULE: 8 XXX

toyota_corolla_2017_pt.dbc
4:BO_ 548 BRAKE_MODULE: 8 XXX

toyota_tssp_pt.dbc
4:BO_ 550 BRAKE_MODULE: 8 XXX

toyota_tssp_hybrid.dbc
4:BO_ 550 BRAKE_MODULE: 8 XXX

_toyota_nodsu_common.dbc
14:BO_ 550 BRAKE_MODULE: 8 XXX

lexus_is_2018_pt.dbc
4:BO_ 550 BRAKE_MODULE: 8 XXX

I think we can consider this initial cleanup finished: we now have only three DBCs for all the Toyotas, split up by platform.