is it on purpose or mistake?

Question

is it on purpose or mistake?

springrider opened this issue 7 years ago · comments

4961d9e recovered websocket header config with "websockets_header_files=l*.h
", and months later 66c86a8 reverted it...

minggo · Answer 1 · Tue Mar 07 2017 15:13:24 GMT+0800 (China Standard Time)

it is on purpose, because l*.h will match unneeded header files

springrider · Answer 2 · Tue Mar 07 2017 15:22:00 GMT+0800 (China Standard Time)

the current version of cocos2d-x lite has lws_config.h included. it is not necessary anymore?

minggo · Answer 3 · Tue Mar 07 2017 15:25:39 GMT+0800 (China Standard Time)

it is needed, but can not just use l*.h to match it, may be should create a new issue

springrider · Answer 4 · Tue Mar 07 2017 15:29:04 GMT+0800 (China Standard Time)

I am not sure why, but after change it back to "l*.h", it only copied the necessary file "lws_config.h" and "libwebsockets.h".. which is the correct behaviour...

minggo · Answer 5 · Tue Mar 07 2017 15:32:37 GMT+0800 (China Standard Time)

it is because you only build websocket

springrider · Answer 6 · Tue Mar 07 2017 15:37:33 GMT+0800 (China Standard Time)

right, new issue then, thanks.