brentp / hts-nim

nim wrapper for htslib for parsing genomics data files

Home Page:https://brentp.github.io/hts-nim/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Failure to compile when using new Nim Gas (ORC and ARC)

Benjamin-Lee opened this issue · comments

It doesn't look as it the new GC mechanisms are support yet. This is a bummer since I'm getting a pretty significant speed boost when using them in my code but can't use it anymore if I want to use hts-nim.

~/D/P/R/viroid-search ❯❯❯ cat src/test_htslib.nim                                                                              (viroid-search)
import hts
~/D/P/R/viroid-search ❯❯❯ nim c -d:danger src/test_htslib.nim                                                                  (viroid-search)
Hint: used config file '/usr/local/Cellar/nim/1.4.0/nim/config/nim.cfg' [Conf]
Hint: used config file '/usr/local/Cellar/nim/1.4.0/nim/config/config.nims' [Conf]
.........................
/Users/BenjaminLee/Desktop/Python/Research/viroid-search/src/test_htslib.nim(1, 8) Warning: imported and not used: 'hts' [UnusedImport]
CC: stdlib_assertions.nim
CC: stdlib_system.nim
CC: ../../../../../.nimble/pkgs/hts-0.3.12/hts/private/hts_concat.nim
CC: stdlib_parseutils.nim
CC: stdlib_strutils.nim
CC: ../../../../../.nimble/pkgs/hts-0.3.12/hts/vcf.nim
CC: ../../../../../.nimble/pkgs/hts-0.3.12/hts.nim
CC: test_htslib.nim
Hint:  [Link]
Hint: 47780 lines; 1.759s; 49.484MiB peakmem; Dangerous Release build; proj: /Users/BenjaminLee/Desktop/Python/Research/viroid-search/src/test_htslib.nim; out: /Users/BenjaminLee/Desktop/Python/Research/viroid-search/src/test_htslib [SuccessX]
~/D/P/R/viroid-search ❯❯❯ nim c -d:danger --gc:orc src/test_htslib.nim                                                         (viroid-search)
Hint: used config file '/usr/local/Cellar/nim/1.4.0/nim/config/nim.cfg' [Conf]
Hint: used config file '/usr/local/Cellar/nim/1.4.0/nim/config/config.nims' [Conf]
....................
/Users/BenjaminLee/.nimble/pkgs/hts-0.3.12/hts/vcf.nim(409, 8) Error: cannot bind another '=destroy' to: Variant:ObjectType; previous declaration was constructed here implicitly: /Users/BenjaminLee/.nimble/pkgs/hts-0.3.12/hts/vcf.nim(180, 16)
~/D/P/R/viroid-search ❯❯❯

thanks for reporting. this was fixed in master, but not tagged. I have just tagged v0.3.13 that has the fix.

Wow, that's the fastest fix ever! Thanks!