Available PSets API is broken when `canonical=FALSE`
ChristopherEeles opened this issue · comments
It looks like this API URL is broken: http://www.orcestra.ca/api/psets/available.
As a result, availablePSets()
in PharmacoGx is breaking when canonical=FALSE
.
Could you please look into this?
Best,
Chris
This was caused by a database update. There was a dataset version that was no longer supposed to be there. I updated the dataset version and it works now.
Hi @mnakano,
This issue is occurring again and totally breaks downloadPSet
, since I rely on the availablePSets(canonical=FALSE)
to get the download URls inside of downloadPSet
. Is there a reason this keeps breaking?
Could we maybe setup an automated API test to make sure it gets caught early?
Thanks for your assistance.
Best,
Chris
This is working again. Is it possible to add a test to this API when pushing updates to production for ORCESTRA?
Best,
Chris
Hi @ChristopherEeles ,
Yes, it would be a good idea to add a test to this API. I'll add one to ensure that it gets caught early on.
I'll also add additional checks to prevent the code failure.
Thank you,
Minoru