Available PSets API is broken when `canonical=FALSE`

Question

Available PSets API is broken when `canonical=FALSE`

ChristopherEeles opened this issue 3 years ago · comments

Christopher Eeles commented 3 years ago

Hi @mnakano and @anthfm,

It looks like this API URL is broken: http://www.orcestra.ca/api/psets/available.

As a result, availablePSets() in PharmacoGx is breaking when canonical=FALSE.

Could you please look into this?

Best,
Chris

mnakano · Answer 1 · Tue Jun 15 2021 05:11:57 GMT+0800 (China Standard Time)

This was caused by a database update. There was a dataset version that was no longer supposed to be there. I updated the dataset version and it works now.

Christopher Eeles · Answer 2 · Fri Jun 25 2021 01:00:49 GMT+0800 (China Standard Time)

Hi @mnakano,

This issue is occurring again and totally breaks downloadPSet, since I rely on the availablePSets(canonical=FALSE) to get the download URls inside of downloadPSet. Is there a reason this keeps breaking?

Could we maybe setup an automated API test to make sure it gets caught early?

Thanks for your assistance.

Best,
Chris

Christopher Eeles · Answer 3 · Fri Jun 25 2021 02:31:21 GMT+0800 (China Standard Time)

This is working again. Is it possible to add a test to this API when pushing updates to production for ORCESTRA?

Best,
Chris

mnakano · Answer 4 · Fri Jun 25 2021 03:20:58 GMT+0800 (China Standard Time)

Hi @ChristopherEeles ,

Yes, it would be a good idea to add a test to this API. I'll add one to ensure that it gets caught early on.
I'll also add additional checks to prevent the code failure.

Thank you,

Minoru