ashleve / lightning-hydra-template

PyTorch Lightning + Hydra. A very user-friendly template for ML experimentation. ⚡🔥⚡

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Question regarding the licensing terms of the template

matthewcarbone opened this issue · comments

Hi @ashleve. First of all, wonderful repository, thank you. I have a question about the terms of use that are outlined in your license in the readme. When copied as a template, your readme says to delete everything above a certain line. This includes deleting the license for your code, and there is no standard LICENSE file in the codebase. This makes the terms of use for the template somewhat unclear. You might want to include a LICENSE file in the code itself that comes along with the template so it's obvious that people still need to use your license, or release without a license (should you wish)!

commented

I deleted the LICENSE file because it's up to the user to choose their project license.

I can see how this is confusing though since license in readme contains statement:

"The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."

The only reason I included MIT license in the readme was to let people know they can use this repo however they want.

I guess I will just drop the license from readme and not include it anywhere at all so there's no confusion.

@ashleve It's really amazing of you to provide this as is and without a license, but yes based on my experience/understanding, your code is licensed under MIT and as such people are technically supposed to include it with any modified distribution of your code.

Anyways thank you for what you've done here. It's really phenomenal and is helping me quite a bit.

@ashleve not related to this issue, but I just wanted to say thank you for such a wonderful template. I have turned this into a project for training ML models, which I've used in quite a few scientific works. I plan on releasing it on PyPI soon so others can benefit. 😊