ami-iit / bipedal-locomotion-framework

Suite of libraries for achieving bipedal locomotion on humanoid robots

Home Page:https://ami-iit.github.io/bipedal-locomotion-framework/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong parameter type in centroidal MPC documentation

CarlottaSartore opened this issue · comments

The documentation for the centroidal mpc parameter has some issues (at least if one want to set the parameter via code rather than via conf file):

* | `sampling_time` | `double` | Sampling time of the MPC. | Yes |
* | `time_horizon` | `double` | The time horizon of the MPC. The number of knots will be given by `floor(time_horizon / sampling_time)` | Yes |

the time_horizon and sampling_time variable are datetime rather than double.

In addition, the unit is missing (I assume they are seconds).

@GiulioRomualdi if you want (and agree) I can fix them either in #650 or open a new PR ! Let me know

You can open a PR! Thank you 😀