aacanakin / space-challenge

a poc on atomic design, typescript, redux, ad-cli and more

space-challenge

This is a poc on how to atomic design, typescript, react-redux with ad-cli.

Getting Started

• Clone the repo

git clone [e-mail]:aacanakin/space-challenge.git

• Install dependencies on repository root folder

cd space-challenge
npm install

• Build

rm -rf coverage && npm run build

• Serve the app

npm install -g serve
serve -s build

• Navigate to http://localhost:5000

Tests

To run tests, perform the following command on repository root folder;

npm test
npm test -- --coverage # to see coverage report

Future Improvements

• More tests
  • Generic resource store tests
• LaunchDetailsPage & LaunchMissionDetailsPage should be unified with a mode option on container
• Infinite scroll initially requests more than 1 request
  • offset: 0, count: 10,
  • offset: 10, count: 10
  • It should be only 1 request
• LaunchImage
  • LaunchImage should lazily load images using an image loader library
• Travis CI integration
  • Build badge
  • Code coverage badge
• Componentize LaunchMissionList & LaunchMissionListItem