YosysHQ / fpga-toolchain

Multi-platform nightly builds of open source FPGA tools

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

using dos2unix instead of changing git global setting?

sylefeb opened this issue · comments

Hi, great repo! I wanted to make a suggestion regarding the following in the yices2 script:

# TODO: handle this better so I don't mess with people's dev envs
git config --global core.autocrlf false

As a Windows/mingw/cygwin user I definitely would not want my global git autocrlf changed. Maybe it would be possible to use dos2unix which at least on msys2 (mingw) can be installed easily (pacman -S dos2unix)?

Hope this helps -

Hi, I haven't been putting a lot of effort into this any more as I think it's largely superseded by https://github.com/YosysHQ/oss-cad-suite-build. This issue is only really a problem if you're running the scripts locally for development, but I agree it's not ideal. I do apologise that I never resurrected the windows build (perhaps you were looking into fixing that yourself) but a couple of the tools enabled link-time optimisation (LTO) upstream which is broken on mingw64 and it looked like it would be a reasonable amount of effort to turn LTO off in these builds...