Unused variable m_MoveWindowInProgress

Question

Unused variable m_MoveWindowInProgress

Sahasrara opened this issue 3 years ago · comments

I don't see m_MoveWindowInProgress being used. Is that a bug?

Rodney S. Foley · Answer 1 · Sat Feb 12 2022 05:07:56 GMT+0800 (China Standard Time)

It is being used it just is in the Update method to return if a move is in progress. I think the bug is that it is not being set to change its state while the move is in progress.

So OnDisplayChanged should set this to true before starting the Coroutine, and the MoveToDisplay Coroutine should set it to false in its finally statement. This would prevent the Update method from doing anything while the coroutine is running. Which seems like the intention of the code.

I made this change locally for myself I can try to make time to get a PR for it later.

Tautvydas Žilys · Answer 2 · Sat Feb 12 2022 09:10:50 GMT+0800 (China Standard Time)

I will fix this. @CreepyGnome no need to open a PR, I'll do it.

Thanks for finding this!