Teichlab / bbknn

Batch balanced KNN

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`n_trees` is now `annoy_n_trees`

opened this issue · comments

Thanks for the great method!

The change of n_trees to annoy_n_trees seems to have broken compatibility with scanpy's bbknn module (sc.pp.external.bbknn). Are there any plans to make changes to that module as well?

Thanks for the heads up, I'll pull request in the up to date argument names. For now feel free to use bbknn.bbknn(), which sc.external.pp.bbknn() is just a wrapper for anyway.

Thank you!

I opened a pull request on the day, haven't heard back yet.