SciKit-Surgery / scikit-surgerycalibration

scikit-surgery-calibration provides algorithms designed for the calibration of surgical instruments

Home Page:http://scikit-surgery.github.io/scikit-surgery/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update OpenCV version

thompson318 opened this issue · comments

As v0.1.10 I've held back the openCV version as later versions cause a list vs tuple failure, see https://github.com/SciKit-Surgery/scikit-surgerycalibration/actions/runs/1777361950
See if we can fix this. Eddie fixed it like this

_, l_c, l_d, l_rvecs, l_tvecs \
    = cv2.calibrateCamera(left_object_points,
                          left_image_points,
                          image_size,
                          None, None)
# Convert tuples to lists for later editing
l_rvecs = list(l_rvecs)
l_tvecs = list(l_tvecs)

4.5.3.56 works.
4.5.4.58 breaks.
t_vecs and r_vecs become tuples and therefore immutable.