SBF GPS Support

Question

SBF GPS Support

AndreasAntener opened this issue 5 years ago · comments

Andreas Daniel Antener commented 5 years ago

Hi @MatejFranceskin thanks for implementing the SBF driver. I wanted to check with you on recent updates from your end since I'd have some small changes I could push.

Enable "Support" log on Rover and Base by default, handy when analyzing GPS precision
Divide h- and v-accuracy by 2 because they report 2DRMS, otherwise it seems the EPH/EPV values are not comparable with what we get from uBlox for example.

Thoughts?

Plus I could add a PR for supporting it on the PX4 side.

Matej Frančeškin · Answer 1 · Wed Jun 05 2019 15:14:42 GMT+0800 (China Standard Time)

Sounds great!
I suggest that you first submit PR for GpsDrivers and after it is reviewed and merged you go for PX4 side. Note that same GpsDrivers module is used in PX4 Firmware and QGC for base station support.

Andreas Daniel Antener · Answer 2 · Wed Jun 05 2019 16:12:54 GMT+0800 (China Standard Time)

Right. Why was the SBF support not added yet to PX4, just lack of testing or did you still see issues?

Matej Frančeškin · Answer 3 · Wed Jun 05 2019 16:26:40 GMT+0800 (China Standard Time)

I thought it was added to PX4, now I see that changes to gps.cpp didn't go in. It was tested with the AsteRx-m2 on the UAV and base station on QGC. I will check what happened with the merge. The problem is that currently I don't have the hardware to test it.

Andreas Daniel Antener · Answer 4 · Wed Jun 05 2019 16:27:41 GMT+0800 (China Standard Time)

Ok, I did do that change on my end so I could also add a PR for that later.

Matej Frančeškin · Answer 5 · Wed Jun 05 2019 16:32:12 GMT+0800 (China Standard Time)

My changes are stuck in pr-septentrio branch. As I don't have the hardware now, it would be really great if you test it and create a new PR.