OctoMap / octomap

An Efficient Probabilistic 3D Mapping Framework Based on Octrees. Contains the main OctoMap library, the viewer octovis, and dynamicEDT3D.

Home Page:http://octomap.github.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Octovis crashes with M1 Mac

kennedy12335 opened this issue · comments

Has anyone been able to successfully run octovis on an M1 Mac?

Similar to #310 when i launch octovis it crashes immediately. Below is the output gotten:

objc[19149]: Class QMacAutoReleasePoolTracker is implemented in both /opt/homebrew/Cellar/qt/6.3.1/lib/QtCore.framework/Versions/A/QtCore (0x104e405d0) and /opt/homebrew/Cellar/qt@5/5.15.5/lib/QtCore.framework/Versions/5/QtCore (0x1049c1310). One of the two will be used. Which one is undefined.
objc[19149]: Class QT_ROOT_LEVEL_POOL__THESE_OBJECTS_WILL_BE_RELEASED_WHEN_QAPP_GOES_OUT_OF_SCOPE is implemented in both /opt/homebrew/Cellar/qt/6.3.1/lib/QtCore.framework/Versions/A/QtCore (0x104e40648) and /opt/homebrew/Cellar/qt@5/5.15.5/lib/QtCore.framework/Versions/5/QtCore (0x1049c1388). One of the two will be used. Which one is undefined.
objc[19149]: Class KeyValueObserver is implemented in both /opt/homebrew/Cellar/qt/6.3.1/lib/QtCore.framework/Versions/A/QtCore (0x104e40670) and /opt/homebrew/Cellar/qt@5/5.15.5/lib/QtCore.framework/Versions/5/QtCore (0x1049c13b0). One of the two will be used. Which one is undefined.
objc[19149]: Class RunLoopModeTracker is implemented in both /opt/homebrew/Cellar/qt/6.3.1/lib/QtCore.framework/Versions/A/QtCore (0x104e406c0) and /opt/homebrew/Cellar/qt@5/5.15.5/lib/QtCore.framework/Versions/5/QtCore (0x1049c1400). One of the two will be used. Which one is undefined.
Usage: path/bin/octovis [mapfile] [tree depth cutoff]
Where the optional [tree depth cutoff] is an integer from 1 to 16
QWidget: Must construct a QApplication before a QWidget
Abort trap: 6
logout

Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

Following this, it crashed immediatley with this error response:

Translated Report (Full Report Below)

Process: octovis [19149]
Path: /Users/USER/Documents/*/octovis
Identifier: octovis
Version: ???
Code Type: ARM-64 (Native)
Parent Process: bash [19120]
Responsible: Terminal [14221]
User ID: 501

Date/Time: 2022-06-22 01:16:40.7036 +0100
OS Version: macOS 12.0.1 (21A559)
Report Version: 12
Anonymous UUID: 49DCE896-3D78-77EC-006D-158E58036164

Sleep/Wake UUID: CCBB233B-38C5-48E1-ABF0-86B788D3D017

Time Awake Since Boot: 280000 seconds
Time Since Wake: 25154 seconds

System Integrity Protection: enabled

Crashed Thread: 0 Dispatch queue: com.apple.main-thread

Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY

Application Specific Information:
abort() called

Kernel Triage:
VM - pmap_enter failed with resource shortage
VM - pmap_enter failed with resource shortage
VM - pmap_enter failed with resource shortage
VM - pmap_enter failed with resource shortage
VM - pmap_enter failed with resource shortage

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0 libsystem_kernel.dylib 0x18aead9b8 __pthread_kill + 8
1 libsystem_pthread.dylib 0x18aee115c pthread_kill + 288
2 libsystem_c.dylib 0x18ae1e314 abort + 164
3 QtCore 0x104a98444 qAbort() + 12
4 QtCore 0x104a9c1c8 qt_message_fatal(QtMsgType, QMessageLogContext const&, QString const&) + 12
5 QtCore 0x104ce4154 QMessageLogger::fatal(char const*, ...) const + 76
6 QtWidgets 0x1054142f8 QWidgetPrivate::QWidgetPrivate(int) (.cold.1) + 52
7 QtWidgets 0x105122248 QWidgetPrivate::QWidgetPrivate(int) + 316
8 QtOpenGLWidgets 0x10282ea9c QOpenGLWidget::QOpenGLWidget(QWidget*, QFlagsQt::WindowType) + 52
9 QGLViewer 0x1029e75ac QGLViewer::QGLViewer(QWidget*, QFlagsQt::WindowType) + 40
10 octovis 0x10245982c octomap::ViewerWidget::ViewerWidget(QWidget*) + 92 (ViewerWidget.cpp:37)
11 octovis 0x102459928 octomap::ViewerWidget::ViewerWidget(QWidget*) + 36 (ViewerWidget.cpp:37)
12 octovis 0x102429a00 octomap::ViewerGui::ViewerGui(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, QWidget*, unsigned int) + 332 (ViewerGui.cpp:53)
13 octovis 0x10242e018 octomap::ViewerGui::ViewerGui(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, QWidget*, unsigned int) + 52 (ViewerGui.cpp:50)
14 octovis 0x1024286ec main + 312 (main.cpp:43)
15 dyld 0x1028810f4 start + 520

Thread 1:
0 libsystem_pthread.dylib 0x18aedc2bc start_wqthread + 0

Thread 2:
0 libsystem_pthread.dylib 0x18aedc2bc start_wqthread + 0

Thread 0 crashed with ARM Thread State (64-bit):
x0: 0x0000000000000000 x1: 0x0000000000000000 x2: 0x0000000000000000 x3: 0x0000000000000000
x4: 0x0000000104db7855 x5: 0x000000016d9da8d0 x6: 0x000000000000000a x7: 0x00000000000000da
x8: 0xa0212e367c69f84f x9: 0xa0212e377ee73dcf x10: 0x0000000000000002 x11: 0x00000000fffffffd
x12: 0x0000000000000000 x13: 0x0000000000000000 x14: 0x0000000000000001 x15: 0x0000000000000002
x16: 0x0000000000000148 x17: 0x00000001e52c7530 x18: 0x0000000000000000 x19: 0x0000000000000006
x20: 0x00000001028ec580 x21: 0x0000000000000103 x22: 0x0000000156623b30 x23: 0x0000000000000000
x24: 0x0000000000000000 x25: 0x0000000000000000 x26: 0x0000000000000000 x27: 0x0000000000000000
x28: 0x0000000000000000 fp: 0x000000016d9da960 lr: 0x000000018aee115c
sp: 0x000000016d9da940 pc: 0x000000018aead9b8 cpsr: 0x40000000
far: 0x0000000104b9a8e0 esr: 0x56000080 Address size fault

Binary Images:
0x18aea4000 - 0x18aed9fff libsystem_kernel.dylib () /usr/lib/system/libsystem_kernel.dylib
0x18aeda000 - 0x18aee6fff libsystem_pthread.dylib (
) <4786e19a-9312-38e6-80ef-9c1394548118> /usr/lib/system/libsystem_pthread.dylib
0x18ada5000 - 0x18ae25fff libsystem_c.dylib () <002a39ae-6431-3b2e-85e7-c45fc2f95ad0> /usr/lib/system/libsystem_c.dylib
0x104a90000 - 0x104e2ffff org.qt-project.QtCore (6.3) /opt/homebrew/
/QtCore.framework/Versions/A/QtCore
0x1050e8000 - 0x1054b3fff org.qt-project.QtWidgets (6.3) /opt/homebrew//QtWidgets.framework/Versions/A/QtWidgets
0x102828000 - 0x10282ffff org.qt-project.QtOpenGLWidgets (6.3) <36fe195b-056e-38aa-bdc3-34e9f0ebed9a> /opt/homebrew/
/QtOpenGLWidgets.framework/Versions/A/QtOpenGLWidgets
0x1029e0000 - 0x102a4bfff com.yourcompany.QGLViewer (2.8) /Library/Frameworks/QGLViewer.framework/Versions/2/QGLViewer
0x102424000 - 0x10247bfff octovis () <18d83b22-c741-3644-84a8-ae570591c146> /Users/USER/Documents//octovis
0x10287c000 - 0x1028dbfff dyld (*) <86a8ba48-8bb4-3b30-9cda-051f73c74f44> /usr/lib/dyld

External Modification Summary:
Calls made by other processes targeting this process:
task_for_pid: 0
thread_create: 0
thread_set_state: 0
Calls made by this process:
task_for_pid: 0
thread_create: 0
thread_set_state: 0
Calls made by all processes on this machine:
task_for_pid: 0
thread_create: 0
thread_set_state: 0

VM Region Summary:
ReadOnly portion of Libraries: Total=863.4M resident=0K(0%) swapped_out_or_unallocated=863.4M(100%)
Writable regions: Total=952.8M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=952.8M(100%)

                            VIRTUAL   REGION 

REGION TYPE SIZE COUNT (non-coalesced)
=========== ======= =======
Activity Tracing 256K 1
ColorSync 496K 24
CoreGraphics 32K 2
Foundation 16K 1
Kernel Alloc Once 32K 1
MALLOC 199.3M 29
MALLOC guard page 192K 9
MALLOC_MEDIUM (reserved) 360.0M 3 reserved VM address space (unallocated)
MALLOC_NANO (reserved) 384.0M 1 reserved VM address space (unallocated)
STACK GUARD 56.0M 3
Stack 9264K 3
VM_ALLOCATE 1.0G 4
__AUTH 1790K 149
__AUTH_CONST 9917K 295
__DATA 9425K 333
__DATA_CONST 11.5M 350
__DATA_DIRTY 595K 100
__FONT_DATA 4K 1
__LINKEDIT 587.5M 59
__OBJC_CONST 1239K 123
__OBJC_RO 81.8M 1
__OBJC_RW 3088K 1
__TEXT 275.9M 366
__UNICODE 588K 1
dyld private memory 1024K 1
mapped file 144.8M 18
shared memory 864K 15
=========== ======= =======
TOTAL 3.1G 1894
TOTAL, minus reserved VM space 2.4G 1894


Full Report

{"app_name":"octovis","timestamp":"2022-06-22 01:16:40.00 +0100","app_version":"","slice_uuid":"18d83b22-c741-3644-84a8-ae570591c146","build_version":"","platform":1,"share_with_app_devs":1,"is_first_party":1,"bug_type":"309","os_version":"macOS 12.0.1 (21A559)","incident_id":"BACB6FC4-FE96-443A-A64A-A131DF6AE5B8","name":"octovis"}
{
"uptime" : 280000,
"procLaunch" : "2022-06-22 01:16:40.2000 +0100",
"procRole" : "Background",
"version" : 2,
"userID" : 501,
"deployVersion" : 210,
"modelCode" : "MacBookPro17,1",
"procStartAbsTime" : 6880820511903,
"coalitionID" : 13016,
"osVersion" : {
"train" : "macOS 12.0.1",
"build" : "21A559",
"releaseType" : "User"
},
"captureTime" : "2022-06-22 01:16:40.7036 +0100",
"incident" : "BACB6FC4-FE96-443A-A64A-A131DF6AE5B8",
"bug_type" : "309",
"pid" : 19149,
"procExitAbsTime" : 6880832502673,
"translated" : false,
"cpuType" : "ARM-64",
"procName" : "octovis",
"procPath" : "/Users/USER/Documents//octovis",
"parentProc" : "bash",
"parentPid" : 19120,
"coalitionName" : "com.apple.Terminal",
"crashReporterKey" : "49DCE896-3D78-77EC-006D-158E58036164",
"responsiblePid" : 14221,
"responsibleProc" : "Terminal",
"wakeTime" : 25154,
"sleepWakeUUID" : "CCBB233B-38C5-48E1-ABF0-86B788D3D017",
"sip" : "enabled",
"isCorpse" : 1,
"exception" : {"codes":"0x0000000000000000, 0x0000000000000000","rawCodes":[0,0],"type":"EXC_CRASH","signal":"SIGABRT"},
"ktriageinfo" : "VM - pmap_enter failed with resource shortage\nVM - pmap_enter failed with resource shortage\nVM - pmap_enter failed with resource shortage\nVM - pmap_enter failed with resource shortage\nVM - pmap_enter failed with resource shortage\n",
"asi" : {"libsystem_c.dylib":["abort() called"]},
"extMods" : {"caller":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"system":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"targeted":{"thread_create":0,"thread_set_state":0,"task_for_pid":0},"warnings":0},
"faultingThread" : 0,
"threads" : [{"triggered":true,"id":2971936,"threadState":{"x":[{"value":0},{"value":0},{"value":0},{"value":0},{"value":4376459349},{"value":6134016208},{"value":10},{"value":218},{"value":11538554531850352719},{"value":11538554536187084239},{"value":2},{"value":4294967293},{"value":0},{"value":0},{"value":1},{"value":2},{"value":328},{"value":8139863344},{"value":0},{"value":6},{"value":4337878400,"symbolLocation":0,"symbol":"_main_thread"},{"value":259},{"value":5744245552},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0},{"value":0}],"flavor":"ARM_THREAD_STATE64","lr":{"value":6625825116},"cpsr":{"value":1073741824},"fp":{"value":6134016352},"sp":{"value":6134016320},"esr":{"value":1442840704,"description":" Address size fault"},"pc":{"value":6625614264,"matchesCrashFrame":1},"far":{"value":4374243552}},"queue":"com.apple.main-thread","frames":[{"imageOffset":39352,"symbol":"__pthread_kill","symbolLocation":8,"imageIndex":0},{"imageOffset":29020,"symbol":"pthread_kill","symbolLocation":288,"imageIndex":1},{"imageOffset":496404,"symbol":"abort","symbolLocation":164,"imageIndex":2},{"imageOffset":33860,"symbol":"qAbort()","symbolLocation":12,"imageIndex":3},{"imageOffset":49608,"symbol":"qt_message_fatal(QtMsgType, QMessageLogContext const&, QString const&)","symbolLocation":12,"imageIndex":3},{"imageOffset":2441556,"symbol":"QMessageLogger::fatal(char const
, ...) const","symbolLocation":76,"imageIndex":3},{"imageOffset":3326712,"symbol":"QWidgetPrivate::QWidgetPrivate(int) (.cold.1)","symbolLocation":52,"imageIndex":4},{"imageOffset":238152,"symbol":"QWidgetPrivate::QWidgetPrivate(int)","symbolLocation":316,"imageIndex":4},{"imageOffset":27292,"symbol":"QOpenGLWidget::QOpenGLWidget(QWidget*, QFlagsQt::WindowType)","symbolLocation":52,"imageIndex":5},{"imageOffset":30124,"symbol":"QGLViewer::QGLViewer(QWidget*, QFlagsQt::WindowType)","symbolLocation":40,"imageIndex":6},{"imageOffset":219180,"sourceLine":37,"sourceFile":"ViewerWidget.cpp","symbol":"octomap::ViewerWidget::ViewerWidget(QWidget*)","imageIndex":7,"symbolLocation":92},{"imageOffset":219432,"sourceLine":37,"sourceFile":"ViewerWidget.cpp","symbol":"octomap::ViewerWidget::ViewerWidget(QWidget*)","imageIndex":7,"symbolLocation":36},{"imageOffset":23040,"sourceLine":53,"sourceFile":"ViewerGui.cpp","symbol":"octomap::ViewerGui::ViewerGui(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, QWidget*, unsigned int)","imageIndex":7,"symbolLocation":332},{"imageOffset":40984,"sourceLine":50,"sourceFile":"ViewerGui.cpp","symbol":"octomap::ViewerGui::ViewerGui(std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > const&, QWidget*, unsigned int)","imageIndex":7,"symbolLocation":52},{"imageOffset":18156,"sourceLine":43,"sourceFile":"main.cpp","symbol":"main","imageIndex":7,"symbolLocation":312},{"imageOffset":20724,"symbol":"start","symbolLocation":520,"imageIndex":8}]},{"id":2971963,"frames":[{"imageOffset":8892,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":1}]},{"id":2971964,"frames":[{"imageOffset":8892,"symbol":"start_wqthread","symbolLocation":0,"imageIndex":1}]}],
"usedImages" : [
{
"source" : "P",
"arch" : "arm64e",
"base" : 6625574912,
"size" : 221184,
"uuid" : "c8524c02-b14f-30bd-a228-c44b4a448e68",
"path" : "/usr/lib/system/libsystem_kernel.dylib",
"name" : "libsystem_kernel.dylib"
},
{
"source" : "P",
"arch" : "arm64e",
"base" : 6625796096,
"size" : 53248,
"uuid" : "4786e19a-9312-38e6-80ef-9c1394548118",
"path" : "/usr/lib/system/libsystem_pthread.dylib",
"name" : "libsystem_pthread.dylib"
},
{
"source" : "P",
"arch" : "arm64e",
"base" : 6624530432,
"size" : 528384,
"uuid" : "002a39ae-6431-3b2e-85e7-c45fc2f95ad0",
"path" : "/usr/lib/system/libsystem_c.dylib",
"name" : "libsystem_c.dylib"
},
{
"source" : "P",
"arch" : "arm64",
"base" : 4373151744,
"CFBundleShortVersionString" : "6.3",
"CFBundleIdentifier" : "org.qt-project.QtCore",
"size" : 3801088,
"uuid" : "e2dedb0e-f229-348c-8d89-838635737d64",
"path" : "/opt/homebrew//QtCore.framework/Versions/A/QtCore",
"name" : "QtCore",
"CFBundleVersion" : "6.3.1"
},
{
"source" : "P",
"arch" : "arm64",
"base" : 4379803648,
"CFBundleShortVersionString" : "6.3",
"CFBundleIdentifier" : "org.qt-project.QtWidgets",
"size" : 3981312,
"uuid" : "c39bc60e-5127-3259-9ba4-ea885dcb00a3",
"path" : "/opt/homebrew/
/QtWidgets.framework/Versions/A/QtWidgets",
"name" : "QtWidgets",
"CFBundleVersion" : "6.3.1"
},
{
"source" : "P",
"arch" : "arm64",
"base" : 4337074176,
"CFBundleShortVersionString" : "6.3",
"CFBundleIdentifier" : "org.qt-project.QtOpenGLWidgets",
"size" : 32768,
"uuid" : "36fe195b-056e-38aa-bdc3-34e9f0ebed9a",
"path" : "/opt/homebrew//QtOpenGLWidgets.framework/Versions/A/QtOpenGLWidgets",
"name" : "QtOpenGLWidgets",
"CFBundleVersion" : "6.3.1"
},
{
"source" : "P",
"arch" : "arm64",
"base" : 4338876416,
"CFBundleShortVersionString" : "2.8",
"CFBundleIdentifier" : "com.yourcompany.QGLViewer",
"size" : 442368,
"uuid" : "c1fb5c7a-7185-3f8a-9236-a1014886cd96",
"path" : "/Library/Frameworks/QGLViewer.framework/Versions/2/QGLViewer",
"name" : "QGLViewer",
"CFBundleVersion" : "2.8.0"
},
{
"source" : "P",
"arch" : "arm64",
"base" : 4332863488,
"size" : 360448,
"uuid" : "18d83b22-c741-3644-84a8-ae570591c146",
"path" : "/Users/USER/Documents/
/octovis",
"name" : "octovis"
},
{
"source" : "P",
"arch" : "arm64e",
"base" : 4337418240,
"size" : 393216,
"uuid" : "86a8ba48-8bb4-3b30-9cda-051f73c74f44",
"path" : "/usr/lib/dyld",
"name" : "dyld"
}
],
"sharedCache" : {
"base" : 6622625792,
"size" : 3072180224,
"uuid" : "a6162d66-93e3-3251-93cc-b11f7c8c830e"
},
"vmSummary" : "ReadOnly portion of Libraries: Total=863.4M resident=0K(0%) swapped_out_or_unallocated=863.4M(100%)\nWritable regions: Total=952.8M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=952.8M(100%)\n\n VIRTUAL REGION \nREGION TYPE SIZE COUNT (non-coalesced) \n=========== ======= ======= \nActivity Tracing 256K 1 \nColorSync 496K 24 \nCoreGraphics 32K 2 \nFoundation 16K 1 \nKernel Alloc Once 32K 1 \nMALLOC 199.3M 29 \nMALLOC guard page 192K 9 \nMALLOC_MEDIUM (reserved) 360.0M 3 reserved VM address space (unallocated)\nMALLOC_NANO (reserved) 384.0M 1 reserved VM address space (unallocated)\nSTACK GUARD 56.0M 3 \nStack 9264K 3 \nVM_ALLOCATE 1.0G 4 \n__AUTH 1790K 149 \n__AUTH_CONST 9917K 295 \n__DATA 9425K 333 \n__DATA_CONST 11.5M 350 \n__DATA_DIRTY 595K 100 \n__FONT_DATA 4K 1 \n__LINKEDIT 587.5M 59 \n__OBJC_CONST 1239K 123 \n__OBJC_RO 81.8M 1 \n__OBJC_RW 3088K 1 \n__TEXT 275.9M 366 \n__UNICODE 588K 1 \ndyld private memory 1024K 1 \nmapped file 144.8M 18 \nshared memory 864K 15 \n=========== ======= ======= \nTOTAL 3.1G 1894 \nTOTAL, minus reserved VM space 2.4G 1894 \n",
"legacyInfo" : {
"threadTriggered" : {
"queue" : "com.apple.main-thread"
}
},
"trialInfo" : {
"rollouts" : [
{
"rolloutId" : "607844aa04477260f58a8077",
"factorPackIds" : {
"SIRI_MORPHUN_ASSETS" : "6103050cbfe6dc472e1c982a"
},
"deploymentId" : 240000066
},
{
"rolloutId" : "60da5e84ab0ca017dace9abf",
"factorPackIds" : {

  },
  "deploymentId" : 240000008
},
{
  "rolloutId" : "602ad4dac86151000cf27e46",
  "factorPackIds" : {
    "SIRI_DICTATION_ASSETS" : "61ae8d06da72d16a4beb762e"
  },
  "deploymentId" : 240000303
},
{
  "rolloutId" : "601d9415f79519000ccd4b69",
  "factorPackIds" : {
    "SIRI_TEXT_TO_SPEECH" : "61ef3bd729647d394933a0a6"
  },
  "deploymentId" : 240000416
},
{
  "rolloutId" : "5fb4245a1bbfe8005e33a1e1",
  "factorPackIds" : {

  },
  "deploymentId" : 240000015
},
{
  "rolloutId" : "5fc94383418129005b4e9ae0",
  "factorPackIds" : {

  },
  "deploymentId" : 240000370
},
{
  "rolloutId" : "5ffde50ce2aacd000d47a95f",
  "factorPackIds" : {

  },
  "deploymentId" : 240000162
}

],
"experiments" : [

]
}
}

Model: MacBookPro17,1, BootROM 7429.41.5, proc 8:4:4 processors, 8 GB, SMC
Graphics: Apple M1, Apple M1, Built-In
Display: Color LCD, 2560 x 1600 Retina, Main, MirrorOff, Online
Display: VG279, 1920 x 1080 (1080p FHD - Full High Definition), MirrorOff, Online
Memory Module: LPDDR4
AirPort: Wi-Fi, wl0: Sep 13 2021 21:06:59 version 18.20.310.14.7.8.119 FWID 01-9d72ee4a
Bluetooth: Version (null), 0 services, 0 devices, 0 incoming serial ports
Network Service: Wi-Fi, AirPort, en0
USB Device: USB31Bus
USB Device: USB3.1 Hub
USB Device: USB2.1 Hub
USB Device: Rapoo 2.4G Wireless Device
USB Device: USB 2.0 Hub
USB Device: Microsoft Nano Transceiver 1.1
USB Device: BillBoard Device
USB Device: USB31Bus
Thunderbolt Bus: MacBook Pro, Apple Inc.
Thunderbolt Bus: MacBook Pro, Apple Inc.

I would appreciate any sort of help towards fixing this issue