Namespace and functionality conflict with Tripal Analysis Expression
Ferrisx4 opened this issue · comments
The module uses a generic namespace when loading the NCBI Sample Terms and this conflicts with the same functionality provided by the Tripal Expression Analysis module.
In this module, both the namespace and idspace are ncbi_properties whereas in Tripal Analysis Expression module, these are NCBI Sample Attributes and NCBI_Sample_Terms, respectively.
See the initial discussion here in tripal/tripal_analysis_expression#392 (comment)
The suggested solution by @spficklin and @dsenalik this:
- Change this module to use the following format:
namespace:NCBI BioSample Attributes(instead of ncbi_properties)
idspace:NCBI_BioSample_Attritubes(instead of ncbi_properties) - apply an update to convert old data
- Change how data is loaded from NCBI to be more similar to how it is done in the Tripal Expression Analysis module. It is done on-the-fly in that module instead of loading a hard copy of the XML.
Discussion also mentioned the possibility of having this module take on this functionality alone and for the Tripal Expression Analysis module to depend on this module being installed instead, but the above alternative was favored.
Third item resolved with merged pull request #247