Mayank-Khurmai / PHP-Random-Comics-Mailer

https://www.linkedin.com/in/mayank-khurmai/

http://xkcd.mayankkhurmai.in

Mayank-Khurmai/PHP-Random-Comics-Mailer Issues

One concern with the mail sending script (the Cron) is either making it private or adding a rate-limit / time-check. Having the Cron script in a public directory allows it to be called by anyone, making it possible to brute-force sending massive amounts of emails (Denial of Service attack). Cron should be in non-public directory and called with `php -f`, not `wget` or `curl`. e.g., Have a public webroot folder, then store cron outside of the public webroot, or have the script check whether it has run in the last 5 minutes, and not re-run if the check doesn't pass.
Closed 3 years ago2
`1` shouldn't be in there.
Closed 3 years ago1
Unsubscribe should be a link with a token.
Closed 3 years ago
Not sure why the reply-to address is `xkcd@xkcd.com`
Closed 3 years ago1
Database connection should not need to be repeated. Credentials should not need to be repeated.
Closed 3 years ago
Don't commit credentials to the repo. Set examples.
Closed 3 years ago
This can be done without javascript by setting `type="email"` on the input attributes. See https://www.w3schools.com/tags/att_input_type_email.asp
Closed 3 years ago1
Feedback
Updated 3 years ago5
Reset of my Git rtlearn Repository
Closed 3 years ago4