MIT-LCP / physionet-build

The new PhysioNet platform.

Home Page:https://physionet.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Server error page appears to list @physionet.org domain for the contact email address

tompollard opened this issue · comments

It looks the server error page currently lists the @physionet.org domain. Fine for PhysioNet, but not for Health Data Nexus!

Screen Shot 2024-02-14 at 9 24 27 AM

From a quick look, the template appears to include a variable for the email address (ERROR_EMAIL):
https://github.com/MIT-LCP/physionet-build/blob/dev/physionet-django/templates/500.html

ERROR_EMAIL is included in the example .env file:
https://github.com/MIT-LCP/physionet-build/blob/dev/.env.example

My guess is that the Nexus team just need to update their .env file.

There are a couple of things we could do to help with this sort of issue:

  • Better organizing the .env.example file so it's clear "these are things you need to configure to have a working site" vs "these are things you need to configure in order to enable X optional feature" vs "these are things you might want to customize".

  • Could have a single variable that defines the sender domain so you don't need to configure each email address separately. Alternatively, decouple supports "variable interpolation" in its "ini" format (https://pypi.org/project/python-decouple/#ini-file)

We've set ERROR_EMAIL env in HDN repository in this PR: https://github.com/T-CAIREM/tcairem-terraform/pull/27. Now HDN error pages link to contact@healthdatanexus.ai.

image