Server error page appears to list @physionet.org domain for the contact email address
tompollard opened this issue · comments
From a quick look, the template appears to include a variable for the email address (ERROR_EMAIL
):
https://github.com/MIT-LCP/physionet-build/blob/dev/physionet-django/templates/500.html
ERROR_EMAIL
is included in the example .env file:
https://github.com/MIT-LCP/physionet-build/blob/dev/.env.example
My guess is that the Nexus team just need to update their .env file.
There are a couple of things we could do to help with this sort of issue:
-
Better organizing the .env.example file so it's clear "these are things you need to configure to have a working site" vs "these are things you need to configure in order to enable X optional feature" vs "these are things you might want to customize".
-
Could have a single variable that defines the sender domain so you don't need to configure each email address separately. Alternatively, decouple supports "variable interpolation" in its "ini" format (https://pypi.org/project/python-decouple/#ini-file)
We've set ERROR_EMAIL env in HDN repository in this PR: https://github.com/T-CAIREM/tcairem-terraform/pull/27. Now HDN error pages link to contact@healthdatanexus.ai
.
![image](https://private-user-images.githubusercontent.com/26672113/305040733-4e81d8ad-06a3-4160-bb6f-384d8d2dc586.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAxMjIxNjMsIm5iZiI6MTcyMDEyMTg2MywicGF0aCI6Ii8yNjY3MjExMy8zMDUwNDA3MzMtNGU4MWQ4YWQtMDZhMy00MTYwLWJiNmYtMzg0ZDhkMmRjNTg2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA0VDE5Mzc0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU1NWQyOGUwMTc4ZWI0ZGFkNzVlMTNjODI1MTEzN2UyMDU5Yzk0ZTE3MjVhYjRkOTJhYjM4Y2M0M2YzMjVjNWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vwusostpNEujyZThOsgQJUkNnIIGx0zWAsz9TwZZb94)