This document gives an outline of how the RFC process works and explains how contributors should submit their RFCs to the project.
The RFC process requires that any large top-level organizational changes should be preceded by a "Request For Comments" document just like this one, explaining the proposed change, the motivation behind it, potential drawbacks, and other considerations. These documents are then discussed and revised by the community for some period of time until a maintainer decides that enough discussion has happened and begins a final comment period, after which a final decision is made.
Most smaller changes to Quilt projects (such as bugfixes) can be submitted via the normal GitHub pull request system, however some are substantial enough that we would prefer that members of the community are given some time to discuss the potential change and give their feedback.
While this document describes when RFC's are required on an organizational level, individual organizational units, such as the Quilt Standard Libraries or Quilt Loader teams, may also require RFCs.
A proper RFC is a high quality, well thought out document describing in detail all the possible benefits, drawbacks, and other consequences of the suggested change. A low effort or low quality RFC is likely to be rejected quickly.
Before beginning the process, it can be helpful to discuss your ideas with other community members on our discord server to get a feel for the community's opinion on the issue.
Once you have a good idea of what you want to suggest, and how the community feels about it, you can begin writing your RFC.
When you are ready to submit an RFC, the process will work as follows:
- Fork the RFC git repository
- Copy
0000-template.mdto0000-my-suggestion.md(replacemy-suggestionwith a descriptive name for your RFC). Don't change the number yet; you will replace the0000with your pull request number from GitHub once you have submitted the PR. - Fill in the template. This should be done with care and effort. You are making a major suggestion for a change to the project – take it seriously.
- Submit a pull request. An open pull request represents an RFC which is still in the commentary phase. You will receive comments and feedback from other community members. You should be prepared to revise your RFC in response to some of this feedback.
- Now that you have an open pull request, rename your markdown file to replace
the
0000with your PR number. - Your PR will be labelled with the relevant project team's label. That team will be responsible for handling the RFC process from here on.
- Build consensus among the community and incorporate feedback from others. RFCs with broad support are more likely to be accepted.
- The team responsible for the RFC will discuss the RFC as much as possible in the pull request's comments. Discussion that occurs in other spaces should be summarized in the PR comments.
- When the team responsible for the RFC decides that there has been enough discussion, a member of the team will issue a "motion for final comments". If the motion passes, it begins a 10 day period where the community has the last chance to give feedback on an RFC.
- This step is taken when enough discussion has happened to make a final decision on the issue. It is designed to prevent RFCs from becoming stales.
- A consensus among all community members is not necessary for an RFC to enter the final comment period. However, there should not be a strong consensus against the disposition given for the final comment period, and some argument supporting the decision should be clearly presented somewhere in prior discussion.
- If discussion has gone on for a long time, the team member who motions for final comments should post a summary comment outlining all of the discussion that has occurred.
- Before actually entering the final comment period, all members of the team must sign their approval.
- When a team member motions for final comments, they also give a "disposition" which can be either accept, reject, or postpone. This determines what will happen to the RFC at the end of the final comment period, although the disposition may change during that period.
- At the end of the final comment period, the RFC will be either accepted or
rejected depending on its disposition at the close of the final comment
period.
- If an RFC is accepted, its PR will be merged into the main RFCs repository on GitHub and an issue (or issues) will be created on the relevant repositories to actually implement the changes. This does not necessarily mean that PRs implementing it will be automatically merged. All PRs are still subject to code quality standards and the like.
- If an RFC is rejected, its PR will be closed and the suggested changes will not be implemented.
- An RFC may also be "postponed". This means the RFC is effectively rejected at the moment because it does not fit into the project's near-term goals, but may be accepted at a later date.