KhronosGroup / glTF-Sample-Assets

To store all models and other assets related to glTF

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Models/README.md has broken links

emackey opened this issue · comments

https://github.com/KhronosGroup/glTF-Sample-Assets/blob/main/Models/README.md

This file has paths with parent folder references (../Models.md) to files that are in the same folder as itself.

commented

I think it would be best to modify it as follows to make it consistent.

As Is:

* [Showcase](../Models-showcase.md) for models that are showcased in Khronos publicity. These are usually complex models with high visual quality.
* [Complete](../Models.md) for a complete list of all models.
* [Testing](../Models-testing.md) for models intended to be used for testing of viewers, converts, and other software systems.
* [Core Only](../Models-core.md) for models that only use glTF Core V2.0 features and capabilities (no extensions).
* [Video Tutorials](../Models-video.md) for models used in any glTF Tutorial video.
* [Written Tutorials](../Models-written.md) for models used in a written glTF Tutorial.
* [Issues](../Models-issues.md) for models with one or more issues that need to be resolved.

To Be:

* [Showcase](./Models-showcase.md) (#showcase) for models that are showcased in Khronos publicity. These are usually complex models with high visual quality.
* [Complete](./Models.md) for a complete list of all models.
* [Testing](./Models-testing.md) (#testing) for models intended to be used for testing of viewers, converts, and other software systems.
* [Core Only](./Models-core.md) (#core) for models that only use glTF Core V2.0 features and capabilities (no extensions).
* [Video Tutorials](./Models-video.md) (#video) for models used in any glTF Tutorial video.
* [Written Tutorials](./Models-written.md) (#written) for models used in a written glTF Tutorial.
* [Issues](./Models-issues.md) (#issues) for models with one or more issues that need to be resolved.
commented

If you have any questions, submit an [issue](https://github.com/KhronosGroup/glTF-Sample-Models/issues).

As Is : glTF-Sample-Models
To Be : glTF-Sample-Assets

"screenshot": "screenshot/screenshot.png",

As Is : screenshot.png
To Be : screenshot.jpg

| [Anisotropy Disc Test](AnisotropyDiscTest/README.md)<br>[![Anisotropy Disc Test](AnisotropyDiscTest/screenshot/screenshot.png)](AnisotropyDiscTest/README.md)<br>[Show](https://github.khronos.org/glTF-Sample-Viewer-Release/?model=https://raw.GithubUserContent.com/KhronosGroup/glTF-Sample-Assets/main/./Models/AnisotropyDiscTest/glTF-Binary/AnisotropyDiscTest.glb) -- [Download GLB](https://raw.GithubUserContent.com/KhronosGroup/glTF-Sample-Assets/main/./Models/AnisotropyDiscTest/glTF-Binary/AnisotropyDiscTest.glb) | This model tests the texturemap for KHR_materials_anisotropy.<br>Credit:<br>&copy; 2023, Public. [CC0 1.0 Universal](https://creativecommons.org/publicdomain/zero/1.0/legalcode)<br> - Eric Chadwick for Everything |

As Is : screenshot.png
To Be : screenshot.jpg

@cx20: Your above comments are appreciated and have been fixed in PR #87.
@emackey: Your note on the Models/README links has also been fixed in PR #87.

That PR is schedule for installation on 4 Jan (sooner if there are sufficient reviews of the new models).

This was fixed a while ago.