Reduce notification centre
laurenluz opened this issue · comments
In an effort to limit load on our backend, it would be great to reduce the notification centre
Imo, we should:
- Don't send notifications for received donations less than $1 (neither emails nor in the dapp)
- Don't send notifications for sent donations (neither emails or in the dapp)
- Remove: My project activity - Project published
- Remove: My project activity - Project updated or edited
@divine-comedian @WhyldWanderer @NikolaCreatrix please feel free to add other suggestions of not useful notifications
cc @jainkrati FYI - when we did load testing on the dapp, 35% of the resources were being used up by the notificaiton centre. This is a not very useful service that is impacting important things... like recording donations.
These are great! I would also add:
Project you liked is listed
@jainkrati - who has bandwidth to take this on? This will reduce the load significantly ahead of the polygon round
Checklist
Remove these notifications:
- Donor: Made Donation
- Project Owner: Received Donation (If donation USD value is > $1)
- Project Owner: My project activity - Project published
- Project Owner: My project activity - Project updated or edited
- General User: Project user liked: Project is now listed
Remove these emails
- Project Owner: Received Donation (If donation USD value is > $1)
- Donor: Made Donation
@CarlosQ96 Do you think you will have bandwidth to take it?
@CarlosQ96 pls take this up as a p0. Let me know if you have any other p0 items on plate. I will help you reprioritize.
Thanks, I can take it soon. Finishing p0 about importing the missing donations, currently a draft pr, im cleaning up and will leave it for review in a few hours.
@CarlosQ96 - We should find a way to test to know if this is the root cause of our issues.
In the meantime, for expediency we should turn off the notification center while we work on these issues defined above.
We should remember to turn on the notification center in time for GIVbacks distribution so users are notified of those.
@RamRamez there is a small part that must be done in the frontend, the notification settings are handled directly by your side. Maybe we can disable that view for now.
@CarlosQ96 - We should find a way to test to know if this is the root cause of our issues.
In the meantime, for expediency we should turn off the notification center while we work on these issues defined above.
We should remember to turn on the notification center in time for GIVbacks distribution so users are notified of those.
GIVBack notifications are sent by giveconomy-notificaiton-service, independent of impact-graph.
There is an important question here! should we ignore all notifications that used to be sent during this off time? or do we have to send them suspended notifications after it's enabled?
I feel like the most important ones not to miss are GIVbacks are out...
I honestly don't think it is an issue to just ignore & never send the ones during this time, but curious to hear what @WhyldWanderer or @divine-comedian think
Yes, we can ignore the notifications
Yeah.. I think we can ignore them as well.. how long is the projected period of time for it to be completely down?
my project received a 11 USD donation but no notification and email has been sent for project owner
@maryjaf - Are you sure this service is working for Solana donations? This issue was made with EVM donations in mind (it should eventually work for Solana too)
my project received a 11 USD donation but no notification and email has been sent for project owner
ّI reported this problem on issue about solana notification (# 3559), and Amin said it seems it's related to this issue
@CarlosQ96 - what is the update for this issue?
but what if....
The notifications from the checklist have been disabled. I thought Maryjaf late confirmed the issue were fixed. Can you reconfirm @maryjaf ?
Thanks @CarlosQ96 Yeah the problem related to solana donation notification has been resolved, I had commented on (# 3559)