Add CORS switch in config
aminlatifi opened this issue · comments
Amin Latifi commented
CORS checking cannot be disabled, let's add a config entry to don't/do load cors middleware based on that.
mohammadranjbarz commented
@aminlatifi
We have it already
impact-graph/src/server/bootstrap.ts
Lines 200 to 230 in 89181df
Amin Latifi commented
@aminlatifi We have it already
impact-graph/src/server/bootstrap.ts
Lines 200 to 230 in 89181df
I meant this line
impact-graph/src/server/bootstrap.ts
Line 235 in 89181df
CORS is enabled whole the time
Amin Latifi commented
It's already merge to the staging. Devops can test it
Amin Latifi commented
@mhmdksh let's close this one if you confirm it's done.
Moe Shehab commented
Yes, I can confirm that it's working. We can close this issue now. Thanks @aminlatifi