Unify projects count in projectsByUserId and userByAddress

Question

Unify projects count in projectsByUserId and userByAddress

mohammadranjbarz opened this issue 9 months ago · comments

In userByAddress web service we return all projects count but in projectsByUserId we return active and listed projects.
After I talked with @RamRamez , it's better to return active and listed project, unless if user who requests is the owner of that wallet address then we should return all projects count.

@RamRamez is it ok?
@CarlosQ96 can you take this?

maryjaf · Answer 1 · Tue Sep 12 2023 13:04:40 GMT+0800 (China Standard Time)

Do you have any Idea when this issue will be ready to test? @mohammadranjbarz @CarlosQ96

maryjaf · Answer 2 · Tue Sep 12 2023 22:59:55 GMT+0800 (China Standard Time)

Related to: Giveth/giveth-dapps-v2#3060 (comment)

maryjaf · Answer 3 · Mon Sep 18 2023 23:49:55 GMT+0800 (China Standard Time)

Do you have any Idea when this issue will be ready to test? @mohammadranjbarz @CarlosQ96

Kindly reminder @CarlosQ96

CarlosQ96 · Answer 4 · Mon Sep 18 2023 23:50:44 GMT+0800 (China Standard Time)

I'll work on it between today and tomorrow

CarlosQ96 · Answer 5 · Tue Sep 19 2023 12:45:32 GMT+0800 (China Standard Time)

Finished Pr ill merge tomorrow early so we can test. @maryjaf

maryjaf · Answer 6 · Thu Sep 21 2023 20:38:15 GMT+0800 (China Standard Time)

I tested and by this changes the project count in public profile view for the owner has been affected and it isn't correct
@CarlosQ96 & @mateodaza checked and raised this issue Giveth/giveth-dapps-v2#3203

CarlosQ96 · Answer 7 · Thu Sep 21 2023 23:51:38 GMT+0800 (China Standard Time)

Backend done but need frontend to finalize it. Will leave it here in QA column. @maryjaf
Giveth/giveth-dapps-v2#3203