FCP-INDI / C-PAC

Configurable Pipeline for the Analysis of Connectomes

Home Page:https://fcp-indi.github.io/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

πŸ› Sparsity thresholds not scaling for network centrality

shnizzedy opened this issue Β· comments

Describe the bug

Updated string parameters

from to
[…] […]
'sparsity' 'Sparsity threshold'

― #1396

'threshold_options': ['Significance threshold', 'Sparsity threshold',
'Correlation threshold'],

"sparsity" isn't a valid "threshold_option" since < 1.8.0, but that's the value used to scale the threshold value

# Change sparsity thresholding to % to work with afni
if threshold_option == 'sparsity':
threshold = threshold * 100
if threshold_option == 'sparsity':
test_thresh = threshold / 100.0

Expected behavior

The scaling occurs for 'Sparsity threshold' instead of for 'sparsity' or the threshold range is 0 β€’ 100 instead of 0 β€’ 1 for 'Sparsity threshold'

Acceptance criteria

  • The scaling occurs for 'Sparsity threshold' instead of for 'sparsity'
    or
  • the threshold range is 0 β€’ 100 instead of 0 β€’ 1 for 'Sparsity threshold'

C-PAC version

1.8.0 β€’ 1.8.5

Additional context

Discovered while working on #1998

Fixed in 1.8.6