Edinburgh-Genome-Foundry / DnaWeaver

A route planner for DNA assembly

Home Page:https://dnaweaver.genomefoundry.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug: Max length initialisation

andrewshvv opened this issue · comments

I believe it should be sequence_length + 1 otherwise GoldenGatePartLibrary might be ignored if the whole sequence is from the library.

Because here you make a comparison of this form:

ends_max = min(L + 1, start + self.max_segment_length)

commented

Thanks for reporting this. Can you confirm that the fix you are suggesting is solving your issue? If yes can you open a PR?

Sorry, I thought I have answered.

Yeah, I can confirm it solved the issue, will try to make a PR soon.