linking of video_air fails
booo opened this issue · comments
On my archlinux machine linking of video_air fails:
➜ video git:(master) ✗ make
[ 8%] Built target gf256
[ 24%] Built target fec_speed_test
Scanning dependencies of target db_common
[ 28%] Building C object db_common/CMakeFiles/db_common.dir/db_raw_receive.c.o
[ 32%] Building C object db_common/CMakeFiles/db_common.dir/radiotap/parse.c.o
[ 36%] Building C object db_common/CMakeFiles/db_common.dir/radiotap/radiotap.c.o
[ 40%] Linking C static library libdb_common.a
[ 68%] Built target db_common
[ 72%] Linking CXX executable video_air
/usr/bin/ld: db_common/libdb_common.a(radiotap.c.o):(.bss+0x0): multiple definition of `__packed'; db_common/libdb_common.a(db_raw_receive.c.o):(.bss+0x8): first defined here
collect2: error: ld returned 1 exit status
make[2]: *** [CMakeFiles/video_air.dir/build.make:135: video_air] Error 1
make[1]: *** [CMakeFiles/Makefile2:149: CMakeFiles/video_air.dir/all] Error 2
make: *** [Makefile:149: all] Error 2
My gcc --version is 10.2.0.
If I update the radiotap library code and use the updated code from https://github.com/radiotap/radiotap-library linking works. The relevant fix in the library is:
radiotap/radiotap-library@94984dd
Maybe we should add a git submodule for the radiotap code and keep that module up to date?