AhsanRazaUK / moneybox-withdrawal

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Moneybox Money Withdrawal

The solution contains a .NET core library (Moneybox.App) which is structured into the following 3 folders:

  • Domain - this contains the domain models for a user and an account, and a notification service.
  • Features - this contains two operations, one which is implemented (transfer money) and another which isn't (withdraw money)
  • DataAccess - this contains a repository for retrieving and saving an account (and the nested user it belongs to)

The task

The task is to implement a money withdrawal in the WithdrawMoney.Execute(...) method in the features folder. For consistency, the logic should be the same as the TransferMoney.Execute(...) method i.e. notifications for low funds and exceptions where the operation is not possible.

As part of this process however, you should look to refactor some of the code in the TransferMoney.Execute(...) method into the domain models, and make these models less susceptible to misuse. We're looking to make our domain models rich in behaviour and much more than just plain old objects, however we don't want any data persistance operations (i.e. data access repositories) to bleed into our domain. This should simplify the task of implementing WithdrawMoney.Execute(...).

Guidelines

  • You should spend no more than 1 hour on this task, although there is no time limit
  • You should fork or copy this repository into your own public repository (Github, BitBucket etc.) before you do your work
  • Your solution must compile and run first time
  • You should not alter the notification service or the the account repository interfaces
  • You may add unit/integration tests using a test framework (and/or mocking framework) of your choice
  • You may edit this README.md if you want to give more details around your work (e.g. why you have done something a particular way, or anything else you would look to do but didn't have time)

Once you have completed your work, send us a link to your public repository.

Good luck!


Refactoring - What's new

  • Withdraw and Deposit behaviour introduced in Account.cs
  • Notifying user responsibility moved to User.cs
  • TransferMoney is now essentially Withdraw from From account to Deposit in To account
  • WithdrawMoney Execute method (Required for test) added
  • Unit tests based on mocking repositories added, covering major scenarios of Account, TransferMoney and WithdrawMoney

What more could have done?

  • Perhaps more test scenarios

About


Languages

Language:C# 100.0%