ARM-software / CSAL

Coresight Access Library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

reserved identifier violation

elfring opened this issue · comments

I would like to point out that an identifier like “__included_devmemd_hdoes not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?

Do you mean because identifiers with two leading underscores are reserved for the language implementation? Yes, that's a fair comment. We could change it.

Fixed by 1d80b69, thanks for report.

We'd fix any specific portability issues that are reported, or consider adding further checking/linting options to the build. We currently build with "-Wall -Werror".

We currently build with "-Wall -Werror".

💭 I find such information insufficient for adjusting remaining update candidates.
Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?