zzak / sinatra-recipes

Community contributed recipes and techniques

Home Page:http://recipes.sinatrarb.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Real links to recipes, rather than JS onclicks...

TrevorBramble opened this issue · comments

I was sad to discover tonight that there is no way to pull up individual recipes.

Would a pull request be accepted where the the site is changed to use plain old HTML linking?

commented

There's a bug in production here, if you try to run the app locally: you'll find that the 'permalink' functionality works perfectly and you can pull up any particular recipe with the /p/topic/recipe syntax.

However, in production the layout is ignored when using this method as you can see

I would prefer a pull request that fixes the permalink functionality in production.

Sorry to have let this sit so long.

The only difference I noticed was (when I ran it in production environment) Etags and last modified are filled on the local app, but they don't come across in the headers on the actual production site. Not sure if that's evidence of some larger wonkiness there.

I attempted to reproduce, passing nil to both of those, but while the resulting response headers looks like what I'm seeing on the production site, all of the links work fine. =^/

commented

Hi Trevor,

Thanks for giving it a try, if you can manage to reproduce it and fix the problem that would be great.

Otherwise, feel free to write a patch to simplify things. There's nothing wrong with minimalism especially if it makes things easier to use.

I know what we have now is far from acceptable, but its sort of been on the back burner for a while.

commented

@TrevorBramble I just added a patch to remove the javascripts, please check it.

Thanks. All works as expected now.

Would be nice to get the ajax stuff working as expected, but I think this is the best move for now.