zyrouge / symphony

🎵 Lightweight, elegant music player for Android 9+.

Home Page:https://zyrouge.github.io/symphony/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Bug] "Artist tag value separators" don't apply to Album Artists

dezponia opened this issue · comments

Description

The values defined in the setting "Artist tag value separators" do not apply to the "Album Artist" tags, only the "Artists" tags.

This was previously discussed in the below issue comment and resolved for Artists in that issue:
#93 (comment)

Steps to Reproduce

  1. Add a album from an artist with a "value separator" in both "Artist" and "Album Artist" tags. For example "AB/CD".

  2. Remove slash (/) from the "Artist tag value separators" list in settings.

  3. Navigate to one of the album tracks and open the "Details" view for the track.

  4. Note that "Artists" and "Album Artist" are displayed differently, with one including the slash and the other displaying AB and CD as different "Album Artists".

  5. Optional extra steps:

  6. Enable the "Album Artists" navigation view and scroll through the list to the affected Album Artist.

  7. Note that the Album Artist is split here as well, creating both an AB and CD Album Artist in this view.

Expected Behavior

Artist and Album Artist should share the same "Artist tag value separators" settings and behavior. Alternatively they can have separate "tag value separator" settings but I don't think this is necessary?

Device

  • Device: Fairphone 5
  • OS: Android 13
  • Version: Symphony v2024.1.109

Additional Context

Different file formats have different rules for metadata tags. Some explicitly state that "Album Artists" should not contain multiple values, while this is ok for the "Artists" tag. I think its probably safe to assume that no setting will please everyone so therefor I suggest letting the one "Artist tag value separators" setting control both "Artist" and "Album Artist" tags.

Checklist

Seems like this has already been implemented. Feel free to re-open if you have any issues.

I can confirm this bug appears to be fixed in Symphony v2024.3.110. Thanks for checking it!

I haven't confirmed this but I suspect this is the commit between v2024.1.109 and v2024.3.110 that fixed the issue. Just adding it here for historical purposes. :)
651e2c5