regex not valid for Opentherm RQ commands
bheading opened this issue · comments
When testing an Opentherm command to set the DHW temperature, ramses_rf didn't like it.
09:52:36.445 RQ --- 18:056026 10:133866 --:------ 3220 005 0010383C00 < Corrupt payload: Payload doesn't match '^00[0-9A-F]{4}0{4}$': 0010383C00
2022-09-05T09:52:36.444430 || HGI:056026 | 10:133866 | RQ | opentherm_msg | 38 || {'msg_id': 56, 'msg_type': 'Write-Data', 'msg_name': 'DHWSetpoint', 'value': 60.0, 'description': 'DHW setpoint'}
2022-09-05T09:52:36.849322 || OTB:133866 | HGI:056026 | RP | opentherm_msg | 38 || {'msg_id': 56, 'msg_type': 'Write-Ack', 'msg_name': 'DHWSetpoint', 'value': 60.0, 'description': 'DHW setpoint'}
I'm fairly new to ramses_cc so I hope I'm not misunderstanding the design, but it looks quite appropriate that the two bytes at the end of the RQ packet would be non-zero.
The parser_3220 code looks like it only supports RQ and RP messages, doesn't allow for ' W', so I guessed it must be appropriate to use RQ to do a write operation. And it did seem to work.
Yes: OT only supports RQ & RP - a change, such as above, is done via an RQ|Write-Data