sesameDataGet("KYCG.HM450.Mask.20220123")$recommended has NA value
maximilian-leitheiser opened this issue · comments
Dear SeSAMe developers,
thanks for a great package! I have been using it quite extensively in my research throughout the last year.
I spotted a very minor inaccuracy in the recommended masks for HM450: sesameDataGet("KYCG.HM450.Mask.20220123")$recommended
has exactly one NA value (when it probably should have none). All the other values are apparently fine:
mask_list_HM450 = sesameDataGet("KYCG.HM450.Mask.20220123")
mask_rec_HM450 = mask_list_HM450$recommended
mask_rec_HM450_alt = unique(do.call(c,
mask_list_HM450[sesame:::recommendedMaskNames()[["HM450"]]]))
table(is.na(rec_mask_HM450))
table(is.na(rec_mask_HM450_alt))
setequal(na.omit(rec_mask_HM450), rec_mask_HM450_alt)
As far as I can tell, this has no consequences, since sesame::getMask(platform = "HM450", use_recommended = TRUE) uses the second approach which has no issues. It still confused me for a moment when I came across the discrepency, so I thought a report might still be helpful.
Best,
Max
Thanks for bringing this to our attention. I will fix this in the next EH upload.