zurfyx / angular-custom-modal

Angular2+ Modal / Dialog (with inner component support).

Home Page:https://zurfyx.github.io/angular-custom-modal/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Parent element size limits the modal size

osmanraifgunes opened this issue · comments

I am using modal inside angular-custom-modal. And the size of the modal is not filling page but the content of scroll content.

stackblitz example of this issue (Click the blue buttons)

That's interesting. Apparently, transform: translate3d(0,0,0); is breaking the position: static hack. As you comment that line the modal works back again.

I was checking other modal implementations. Bootstrap does keep the modal in the same place, Material does add a new component at the end of the body. I wonder what the implications moving the modal to the end of the body are; and also the chances of preserving the current API (HTML component to display modal instead of calling modal through service).

I'll have a look at it at some other point. Thanks for the report. You may need to test this further, but you may get this problem sorted (at least temporarily) applying ::ng-deep ng-scrollbar-view { transform: initial }

commented

Any fix on this? I'm having the same issue.

commented

I put this

::ng-deep ng-scrollbar-view { transform: initial !important; }

in my CSS but it didn't fix it