zulip / zulip

Zulip server and web application. Open-source team chat that helps teams stay productive and focused.

Home Page:https://zulip.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Migrate action functions to send event on commit.

prakhar1144 opened this issue · comments

Cases where event is sent due to using (send_event / queue_json_publish) in zerver/actions/ functions even before all the db operations in the action function finishes results in bugs.

Migrate action functions to use send_event_on_commit / queue_event_on_commit.

CZO thread

Hello @zulip/server-misc members, this issue was labeled with the "area: db cleanup" label, so you may want to check it out!

Tagging as a priority because previous migrations of this form have fixed live bugs, and it's likely that there's some other bugs that we've not encountered/reproduced that this transition would fix as well.