Fix inconsistency in README: Code example for inlineArray uses Serial Comma, actual output is Non-Serial

Question

Fix inconsistency in README: Code example for inlineArray uses Serial Comma, actual output is Non-Serial

johnlindquist opened this issue 8 years ago · comments

John Lindquist commented 8 years ago

https://github.com/declandewet/common-tags#commalistsand

^ shows the output
I like apples, bananas, and watermelons

Actual output
I like apples, bananas and watermelons

I'm not sure which you're intending to be the correct behavior.

Related:
If you do support Oxford comma, then you need to support:

"Foo and bar"
The current inline transformer with separator and conjunction options looks like it would only handle:
"Foo, and bar" with a comma.

zspecza · Answer 1 · Tue Jul 19 2016 04:21:09 GMT+0800 (China Standard Time)

@johnlindquist Nice spot! This is a typo. The actual output is correct. The conjunction set by the underlying InlineArrayTransformer is supposed to replace the last comma.