Rewrite to TypeScript

Question

Rewrite to TypeScript

fatfisz opened this issue 4 years ago · comments

fatfisz commented 4 years ago

We should retain all different builds, namely:

CJS as the default entrypoint
ES (set up TypeScript to output something supported by Node 10)
minified UMD (for unpkg.js)

Also package.json should point at the TS declaration file.

Most probably Babel will be removed.

Hexagon · Answer 1 · Thu Mar 30 2023 01:00:38 GMT+0800 (China Standard Time)

@fatfisz I'm interested in making this work on deno+bun natively, and notice it's been a while since this repo were updated. Is proper esm + native ts + cleanup + publish to deno.land/x going to happen? Would you accept a PR, or should i fork the project and re-publish?

Ref: #201

Hexagon · Answer 2 · Thu Mar 30 2023 06:29:28 GMT+0800 (China Standard Time)

I've started working on this, forked and published https://github.com/hexagon/proper-tags to npm and deno.land/x/proper_tags

Currently WIP but should be working!

Nikolai Prokoschenko · Answer 3 · Wed May 24 2023 21:52:20 GMT+0800 (China Standard Time)

@Hexagon since your forked repository does not have issues I'd like to ask here: does the typing for inlineArrayTransformer make sense to you? Typescript does not want to compile because conjunction, separator and serial do not exist on strings and as far as I can see, a string type does not make a lot of sense there.

Hexagon · Answer 4 · Mon Jun 19 2023 07:13:38 GMT+0800 (China Standard Time)

@rassie Issues-section added now, and no, that typing does not make sense. Will have to have a look at that 👍