add secret token

Question

add secret token

jimthedev opened this issue 7 years ago · comments

It would be awesome to be able to place a secret token in stage-ci to take advantage of the webhook secret token functionality that github offers.

zach · Answer 1 · Thu May 11 2017 04:58:54 GMT+0800 (China Standard Time)

Great idea, support.

Jim Cummins · Answer 2 · Thu May 11 2017 21:40:00 GMT+0800 (China Standard Time)

I'll take a stab at this, you can assign to me if you want.

Jim Cummins · Answer 3 · Thu May 11 2017 21:41:34 GMT+0800 (China Standard Time)

BTW, would it be ok if this was added as required if it works? It'd be a breaking change but at the moment anyone running this has an unsecured server that someone could send a bunch of requests to and it would max out their zeit deploys.

zach · Answer 4 · Fri May 12 2017 00:19:13 GMT+0800 (China Standard Time)

@jimthedev Thanks for tackling this! And yes, I think making it required is the way to go from a security standpoint. 👍

Jim Cummins · Answer 5 · Fri May 12 2017 03:27:43 GMT+0800 (China Standard Time)

@zpnk @amccloud you can review the pr but please don't merge until there is a corresponding docs PR

edit: No need to wait anymore. Ready to review and merge.

Jim Cummins · Answer 6 · Fri May 12 2017 12:17:17 GMT+0800 (China Standard Time)

@zpnk @amccloud Ok this is all set. Docs PR is done on the other repo so both should be ready to go whenever you are done reviewing.