zpao / qrcode.react

A <QRCode/> component for use with React.

Home Page:https://zpao.github.io/qrcode.react/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

3.1.0 has no `marginSize` prop in `QRProps`

na2na-p opened this issue · comments

Thanks for a great and cool product!
I found something that could be improved here that might make it better.

AsIs

Release 3.1.0 has no marginSize prop in QRProps.
(Image from node_modules/qrcode.react/lib/index.d.ts)
image

How to reproduce

  1. npm install qrcode.react
  2. Check node_modules/qrcode.react/lib/index.d.ts

ToBe

Even if introduced as an npm package, marginSize prop is available as QRProps as well as the trunk Branch.
(Image from src/index.tsx)
image

Could you also update the registration on npmjs.com?
https://www.npmjs.com/package/qrcode.react

Thank you!

Guess it should be supported in version 3.2.0, when will the new version be released? @zpao

Ah yea, sorry this wasn't shipped in 3.x! I'll get 4.0 out with this (but probably won't bother with 3.x)