zpalmtree / r34-downloader

Downloads all the images of a tag from rule34.paheal.net [NSFW]

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Bug - Images with file names containing Semicolans saves improperly on Windows

fagank-y21 opened this issue · comments

First noticed this with the tag "Felix_Argyle" as file names would contain "Re%3A_Life_in_a_Different_World_from_Zero". When the image is downloaded the name appears truncated from the semicolon onward. After some investigation I've found that Windows treats such a file with semicolons as Alternate Data Streams. The files are written to the disc but just aren't accessible by normal means.

Thanks for the report. This looks like an easy fix, just need to run https://hackage.haskell.org/package/filepath-1.4.2.1/docs/System-FilePath-Windows.html#v:makeValid on the path before saving it.

I'll test it out, might take a little while to get a new build up though, as I don't think I have a development environment setup on windows anymore.

Should be fixed by f07d10a , but have not yet tested on windows. Working on setting up windows environment to test and make a release now.

Tested on windows, and I can download all the files successfully. I have uploaded a new release here - https://github.com/zpalmtree/r34-downloader/releases/tag/v0.1.1

Let me know if it doesn't fix your issue.